-
-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for FlutterAndroidDriver #2203
feat: add support for FlutterAndroidDriver #2203
Conversation
src/e2eFlutterTest/java/io/appium/java_client/android/BaseFlutterTest.java
Show resolved
Hide resolved
src/main/java/io/appium/java_client/flutter/commands/ScrollParameter.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/flutter/commands/WaitParameter.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/flutter/commands/WaitParameter.java
Outdated
Show resolved
Hide resolved
src/e2eFlutterTest/java/io/appium/java_client/android/BaseFlutterTest.java
Outdated
Show resolved
Hide resolved
src/e2eFlutterTest/java/io/appium/java_client/android/CommandTest.java
Outdated
Show resolved
Hide resolved
@@ -206,7 +206,7 @@ public static By iOSNsPredicateString(final String iOSNsPredicateString) { | |||
* @param selector is the value defined to the key attribute of the flutter element | |||
* @return an instance of {@link AppiumBy.ByFlutterKey} | |||
*/ | |||
public static By flutterKey(final String selector) { | |||
public static FlutterBy flutterKey(final String selector) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these changes needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currenlty all flutter script can only work with locators supported by flutter driver. This change is specifically introduced the simplify the API consumption and to prevent the manual type casting when calling the commands.
driver.waitForInVisible(new WaitParameter().setLocator(AppiumBy.flutterKey("message_field")));
Instead of
driver.waitForInVisible(new WaitParameter().setLocator((AppiumBy.FlutterBy)AppiumBy.flutterKey("message_field")));
Change list
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
x
in the boxes that applyDetails
Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub