[fix] whenResultIsFinished works on Promise of Array of Promises #7843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bscherlein: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-server-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
glasser
approved these changes
Mar 5, 2024
| const callback = jest.fn(); | ||
| whenResultIsFinished(result, callback); | ||
| await new Promise((r) => setImmediate(r)); | ||
| expect(callback).toBeCalledWith(null, [expected]); |
There was a problem hiding this comment.
I'm not super positive this is guaranteed (the callback will be called in parallel with the await finishing?) but if the test isn't flaky that's OK for me.
| @@ -113,7 +113,7 @@ export function whenResultIsFinished( | |||
| ) { | |||
| if (isPromise(result)) { | |||
| result.then( | |||
| (r: any) => callback(null, r), | |||
| (r: any) => whenResultIsFinished(r, callback), | |||
There was a problem hiding this comment.
This specifically improves the "Promise of Array of ..." case.
|
Thanks! |
Merged
glasser
pushed a commit
that referenced
this pull request
Mar 5, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/server-integration-testsuite@4.10.1 ### Patch Changes - Updated dependencies \[[`72f568e`](72f568e)]: - @apollo/server@4.10.1 ## @apollo/server@4.10.1 ### Patch Changes - [#7843](#7843) [`72f568e`](72f568e) Thanks [@bscherlein](https://github.com/bscherlein)! - Improves timing of the `willResolveField` end hook on fields which return Promises resolving to Arrays. This makes the use of the `setCacheHint` method more reliable. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with @bbeesley.
Updates whenResultIsFinished to call callback also on Promise of Array of Promises.
Fixes (partially) #5372 and #4667.
The test case we're fixing is
'passes result of Promise of Array of Promises to the callback', the other tests test existing behaviour.The existing bug prevented us from dynamically setting cache hints in the reference resolver depending on the result of an asynchronous operation. We discovered the bug within an integration test. If you @glasser have an idea how to add an integration test and would like to add it, that would be amazing!