Fix trace placement for errors occurring in lists #7699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-server-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d661279:
|
trevor-scheer
commented
Aug 22, 2023
trevor-scheer
commented
Aug 22, 2023
glasser
reviewed
Aug 23, 2023
glasser
approved these changes
Aug 23, 2023
Merged
trevor-scheer
pushed a commit
that referenced
this pull request
Aug 24, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/server-integration-testsuite@4.9.2 ### Patch Changes - Updated dependencies \[[`62e7d940d`](62e7d94)]: - @apollo/server@4.9.2 ## @apollo/server@4.9.2 ### Patch Changes - [#7699](#7699) [`62e7d940d`](62e7d94) Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Fix error path attachment for list items Previously, when errors occurred while resolving a list item, the trace builder would fail to place the error at the correct path and just default to the root node with a warning message: > `Could not find node with path x.y.1, defaulting to put errors on root node.` This change places these errors at their correct paths and removes the log. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4476
Currently, when errors occur while resolving a list item, the trace builder fails to place the error at the correct path and just defaults to the root node with a warning message:
This change places these errors at their correct paths and removes the log.