Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing nonce to script tag #7672

Merged
merged 2 commits into from Aug 4, 2023
Merged

Add missing nonce to script tag #7672

merged 2 commits into from Aug 4, 2023

Conversation

trevor-scheer
Copy link
Member

Follow-up to GHSA-68jh-rf6x-836f

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for apollo-server-docs ready!

Name Link
🔨 Latest commit 44107d3
🔍 Latest deploy log https://app.netlify.com/sites/apollo-server-docs/deploys/64cc3b1c0641c50008144fa8
😎 Deploy Preview https://deploy-preview-7672--apollo-server-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 44107d3:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

@trevor-scheer trevor-scheer merged commit ebfde00 into main Aug 4, 2023
21 checks passed
@trevor-scheer trevor-scheer deleted the trevor/missing-nonce branch August 4, 2023 17:26
@github-actions github-actions bot mentioned this pull request Aug 4, 2023
Copy link
Contributor

@mayakoneval mayakoneval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks sm!

trevor-scheer pushed a commit that referenced this pull request Aug 4, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @apollo/server-integration-testsuite@4.9.1

### Patch Changes

- Updated dependencies
\[[`ebfde0007`](ebfde00)]:
    -   @apollo/server@4.9.1

## @apollo/server@4.9.1

### Patch Changes

- [#7672](#7672)
[`ebfde0007`](ebfde00)
Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Add missing
`nonce` on `script` tag for non-embedded landing page

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants