Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement callback subscription protocol in new plugin ApolloServerPluginSubscriptionCallback #7617

Merged
merged 21 commits into from
Jul 27, 2023
Merged

Implement callback subscription protocol in new plugin ApolloServerPluginSubscriptionCallback #7617

merged 21 commits into from
Jul 27, 2023

Commits on Jun 27, 2023

  1. Initial implementation of plugin

    @trevor-scheer
    trevor-scheer committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    c241ed3 View commit details
    Browse the repository at this point in the history

  2. refactor maps, deduplicate redundant info

    @trevor-scheer
    trevor-scheer committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    8afc606 View commit details
    Browse the repository at this point in the history

  3. one FIXME

    @trevor-scheer
    trevor-scheer committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    855b420 View commit details
    Browse the repository at this point in the history

  4. update plugin export types

    @trevor-scheer
    trevor-scheer committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    7bd798a View commit details
    Browse the repository at this point in the history

  5. update changeset

    @trevor-scheer
    trevor-scheer committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    ea2f768 View commit details
    Browse the repository at this point in the history

  6. cleanup

    @trevor-scheer
    trevor-scheer committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    ee1c3ab View commit details
    Browse the repository at this point in the history

  7. address a couple fixmes

    @trevor-scheer
    trevor-scheer committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    b36baa5 View commit details
    Browse the repository at this point in the history

  8. add test for heartbeat failures

    @trevor-scheer
    trevor-scheer committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    61dbdfb View commit details
    Browse the repository at this point in the history

  9. use 500 instead of 400 status code

    @trevor-scheer
    trevor-scheer committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    29ab4f1 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Respond with valid graphql response

    @trevor-scheer
    trevor-scheer committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    5c93e30 View commit details
    Browse the repository at this point in the history

  2. empty commit to check for CCI hiccup

    @trevor-scheer
    trevor-scheer committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    8beaeae View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. save intermediate constants for reuse later in the block

    @trevor-scheer
    trevor-scheer committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    c904436 View commit details
    Browse the repository at this point in the history

  2. refine log message

    @trevor-scheer
    trevor-scheer committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    61525a8 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. handle unexpected status codes in heartbeat response

    @trevor-scheer
    trevor-scheer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    934ca4b View commit details
    Browse the repository at this point in the history

  2. max failures configurable

    @trevor-scheer
    trevor-scheer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    191e4d0 View commit details
    Browse the repository at this point in the history

  3. don't await in-flight heartbeat to send subscription payload

    @trevor-scheer
    trevor-scheer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    9f09eed View commit details
    Browse the repository at this point in the history

  4. implement retry/error handling on update

    @trevor-scheer
    trevor-scheer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    5ab55aa View commit details
    Browse the repository at this point in the history

  5. use allSettled

    @trevor-scheer
    trevor-scheer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    c0faf33 View commit details
    Browse the repository at this point in the history

  6. set reasonable defaults

    @trevor-scheer
    trevor-scheer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    b187bef View commit details
    Browse the repository at this point in the history

  7. fixme -> xxx; i'm ok with this for now but the comment is worth keepi… 

    …ng around
    @trevor-scheer
    trevor-scheer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    4e3b4b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. retry fetch refactor, consolidate 404/4xx termination logic

    @trevor-scheer
    trevor-scheer committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c7885c8 View commit details
    Browse the repository at this point in the history