one FIXME

apollographql · Jun 23, 2023 · 0f1bde6 · 0f1bde6
1 parent 7341a5a
commit 0f1bde6
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/packages/server/src/plugin/subscriptionCallback/index.ts b/packages/server/src/plugin/subscriptionCallback/index.ts
@@ -540,8 +540,12 @@ class SubscriptionManager {
           });
           self.requestsInFlight.add(completeRequestPromise);
           await completeRequestPromise;
-        } catch {
-          // FIXME: handle this error?
+        } catch (e) {
+          // This is just the `complete` request. If something fails here, we
+          // can still proceed as usual and cleanup the subscription. The router
+          // should just terminate the subscription on its end when it doesn't
+          // receive a heartbeat for it.
+          self.logger?.error(`\`complete\` request failed: ${e}`, id);
         } finally {
           self.requestsInFlight.delete(completeRequestPromise!);
           // clean up the subscription (and heartbeat if necessary)