Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow newer versions of httpx #124

Closed
wants to merge 1 commit into from

Conversation

martolini
Copy link

I've seen this clash with some libraries that want the newest version of httpx. The changelog is here https://github.com/encode/httpx/blob/master/CHANGELOG.md. Would it be possible to allow newer versions of httpx together with this awesome apify client? 馃檹

@fnesveda
Copy link
Member

fnesveda commented May 7, 2023

Hi, thanks for the PR! Unfortunately we can't upgrade HTTPX at this point, so I'll have to close it without merging.

We've actually upgraded to HTTPX 0.24.0 on Friday, but then we've had to quickly downgrade back to 0.23.0 because 0.24.0 had issues parsing IPv6 addresses in the NO_PROXY environment variable, which was breaking some of our workflows. The bug is already fixed in encode/httpx#2659, so we'll upgrade as soon as a new version of HTTPX is released, which should be hopefully soon. 馃檹

In the meantime, before we release a new version, if you think that the above mentioned bug won't affect your usecase, you can use the 1.1.0b3 Apify Client version, which depends on HTTPX 0.24.0, but is otherwise the same as the latest version.

By the way, if you don't mind me asking, what are the libraries that you want to use with this client that require HTTPX 0.24? Just curious.

@fnesveda fnesveda closed this May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants