-
-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Laravel] Graphql simple pagination fix "hasNextPage" #6857
Conversation
Thanks @toitzi could you add a quick test at: https://github.com/api-platform/core/blob/main/src/Laravel/Tests/GraphQlTest.php? |
57f2fe9
to
53ec536
Compare
@soyuka Added a test for the page pagination (simple pagination) |
b5aa0d4
to
6db9b05
Compare
Sorry for the many forced pushs and updates, i cannot test locally the contributing.md guidline seems to be wrong / not working for me since composer global link is not a command, i will try to have a look into that and fix it, maybe you have an idea what i am missing |
Actually you don't need it globally, something like:
should work |
fix loading relationships by only loading those related to the model Closes: api-platform#6791 Signed-off-by: Tobias Oitzinger <tobiasoitzinger@gmail.com>
6db9b05
to
5adb19f
Compare
For whatever reason, that does not work on my machine, probably an issue with my setup, i will try to fix it. Sorry in the meantime. Tests should now pass. |
No worries when you push it cancels the previous workflow. https://github.com/soyuka/pmu is used to link dependencies inside the monorepository. |
@soyuka the tests now pass, the phpstan error is because of some parrallel run, not because of this pr. |
yes I'm thinking about disabling the parallel execution... |
fix loading relationships by only loading those related to the model Closes: api-platform#6791 Signed-off-by: Tobias Oitzinger <tobiasoitzinger@gmail.com>
Also adds "currentPage" to graphql.