Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix CI #6144

Merged
merged 6 commits into from
Feb 4, 2024
Merged

chore: fix CI #6144

merged 6 commits into from
Feb 4, 2024

Conversation

vincentchalamon
Copy link
Contributor

@vincentchalamon vincentchalamon commented Feb 2, 2024

Note: Symfony dev CI jobs are failing because of symfony/symfony#50864

Fix CS

src/GraphQl/Resolver/Factory/ResolverFactory.php resolve private method has been updated to allow null default value (required as required arguments cannot be declared after optional ones).

Fix nullable_type_declaration_for_default_null_value CS rule (nullable_type_declaration_for_default_null_value.use_nullable_type_declaration is now enabled by default in PHP CS Fixer - cf. PHP-CS-Fixer/PHP-CS-Fixer#7773)

Fix PHPUnit Doctrine jobs

Fix self deprecation (missing configuration in component tests).

Since api-platform/core 3.2: Using doctrine/inflector is deprecated since API Platform 3.2 and will be removed in API Platform 4. Use symfony/string instead. Run "composer require symfony/string" and set "keep_legacy_inflector" to false in config.

Fix Doctrine ORM enable_lazy_ghost_objects deprecation in tests configuration

Doctrine ORM enable_lazy_ghost_objects must be set to true in configuration (cf. doctrine/DoctrineBundle#1733).

Since doctrine/doctrine-bundle 2.11: Not setting "enable_lazy_ghost_objects" to true is deprecated.

@vincentchalamon vincentchalamon self-assigned this Feb 2, 2024
@vincentchalamon vincentchalamon changed the title chore: disable keep_legacy_inflector in Doctrine tests chore: fix CI Feb 3, 2024
@vincentchalamon vincentchalamon marked this pull request as ready for review February 3, 2024 19:12
@soyuka soyuka merged commit 8a35ee2 into api-platform:main Feb 4, 2024
70 of 72 checks passed
@vincentchalamon vincentchalamon deleted the fix/ci-main branch February 4, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants