Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Laravel] Graphql simple pagination fix "hasNextPage" #6857

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

toitzi
Copy link
Contributor

@toitzi toitzi commented Dec 9, 2024

Q A
Branch? 4.x
Tickets Closes #6856
License MIT
Doc PR -

Also adds "currentPage" to graphql.

@soyuka
Copy link
Member

soyuka commented Dec 13, 2024

@toitzi toitzi force-pushed the toitzi/pagination branch 5 times, most recently from 57f2fe9 to 53ec536 Compare December 13, 2024 13:40
@toitzi
Copy link
Contributor Author

toitzi commented Dec 13, 2024

@soyuka Added a test for the page pagination (simple pagination)

@toitzi toitzi force-pushed the toitzi/pagination branch 3 times, most recently from b5aa0d4 to 6db9b05 Compare December 13, 2024 14:01
@toitzi
Copy link
Contributor Author

toitzi commented Dec 13, 2024

Sorry for the many forced pushs and updates, i cannot test locally the contributing.md guidline seems to be wrong / not working for me since composer global link is not a command, i will try to have a look into that and fix it, maybe you have an idea what i am missing

@soyuka
Copy link
Member

soyuka commented Dec 13, 2024

composer global require soyuka/pmu ?

Actually you don't need it globally, something like:

cd src/Laravel
composer link ../../
./vendor/bin/testbench package:test

should work

Verified

This commit was signed with the committer’s verified signature.
toitzi Tobias Oitzinger
fix loading relationships by only loading those related to the model

Closes: api-platform#6791
Signed-off-by: Tobias Oitzinger <tobiasoitzinger@gmail.com>
@toitzi
Copy link
Contributor Author

toitzi commented Dec 13, 2024

For whatever reason, that does not work on my machine, probably an issue with my setup, i will try to fix it. Sorry in the meantime. Tests should now pass.

@soyuka
Copy link
Member

soyuka commented Dec 13, 2024

No worries when you push it cancels the previous workflow. https://github.com/soyuka/pmu is used to link dependencies inside the monorepository.

@toitzi
Copy link
Contributor Author

toitzi commented Dec 13, 2024

@soyuka the tests now pass, the phpstan error is because of some parrallel run, not because of this pr.

@soyuka
Copy link
Member

soyuka commented Dec 13, 2024

yes I'm thinking about disabling the parallel execution...

@soyuka soyuka merged commit e0f8c38 into api-platform:4.0 Dec 13, 2024
58 of 59 checks passed
vinceAmstoutz pushed a commit to vinceAmstoutz/api-platform-core that referenced this pull request Dec 24, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
fix loading relationships by only loading those related to the model

Closes: api-platform#6791

Signed-off-by: Tobias Oitzinger <tobiasoitzinger@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants