Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove React 16.4's obsolete React imports #28571

Merged
merged 10 commits into from
Jun 5, 2024
Merged

chore: remove React 16.4's obsolete React imports #28571

merged 10 commits into from
Jun 5, 2024

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented May 18, 2024 •
edited

chore: remove unused React imports

SUMMARY

React imports are no longer necessary starting from React 16.4.0 (source), I ran npx react-codemod update-react-imports. Afterwards, I executed this snippet to confirm everything stays intact

npm ci
npm run build
npm run test
npm run dev-server

Notable changes:

  • Added ESLint configs as recommended per React doc
  • Added Babel and Webpack configs to allow working with new automatic JSX runtime.
  • Fix a build warning due to a type import misdirected as normal import.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

All CI should be green

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hainenber
chore: remove unused React imports
9d5cdaf 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@dosubot dosubot bot added the change:frontend Requires changing the frontend label May 18, 2024
@github-actions github-actions bot added plugins packages and removed change:frontend Requires changing the frontend labels May 18, 2024
@hainenber
fix(ci): rectify failed core:coverCI job
e7d2784 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber hainenber changed the title chore: remove unused React imports chore: remove obsolete React imports May 18, 2024
@hainenber
Copy link
Contributor Author

Converting this to draft as there are weird behaviors after removal

@hainenber hainenber marked this pull request as draft May 18, 2024 13:44
@hainenber
chore: refactor whole React import to destructured format
e981444 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@github-actions github-actions bot added the doc Namespace | Anything related to documentation label May 19, 2024
@hainenber
chore: remove fail-fast Jest config orignally used for development
dbef64a 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
fix(ci): switch to @emotion/babel-plugin for new React 16.4+ automa…
593b8b0 
…tic JSX runtime bundling

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
fix(ci): add ts-ignore directive for unused React import
0c64a46 
This is required to pass corresponding Jest test.

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
chore(build): fix build warning of type import
d8c59eb 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber hainenber changed the title chore: remove obsolete React imports chore: remove React 16.4's obsolete React imports May 19, 2024
@hainenber
Copy link
Contributor Author

Phew! I've worked out all the edge cases and CI is green now, re-open for review :D

@hainenber hainenber marked this pull request as ready for review May 19, 2024 14:58
@dosubot dosubot bot added the change:frontend Requires changing the frontend label May 19, 2024
@michael-s-molina
Copy link
Member

Thank you for the PR @hainenber. Can we add a lint rule to prevent unused React imports?

@hainenber
Merge branch 'master' into remove-unused-react-imports
4dfe1dc 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
feat(build): add eslint rule to detect unused React imports
391b9f9 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
fix(build): add rule exception for warranted React import
243accd 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
Copy link
Contributor Author

I've added the lint rule as requested :D

rusackas
rusackas reviewed Jun 3, 2024
View reviewed changes
superset-frontend/packages/superset-ui-core/src/chart/components/reactify.tsx
@@ -17,7 +17,8 @@
* under the License.
*/

import React from 'react';
// eslint-disable-next-line no-restricted-syntax -- whole React import is required for `reactify.test.tsx` Jest test passing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the comments!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should clarify that I was unable to refactor the reactify.test.tsx to decouple it from whole React import :(

I hope someone much better than me can do the needful in the future.

rusackas
rusackas approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to review this big of a PR is giving my browser a heart attack, and making my eyes bleed :P

I've reviewed about 700 of the files in a somewhat random order, and all looks good to me.

GitHub makes me "load diff" for the rest of the files, and it takes foreeeeeeeever. You would think filtering by file type or filtering out "viewed" files would help, but NOPE.

@michael-s-molina michael-s-molina merged commit 0ca42a8 into apache:master Jun 5, 2024
32 checks passed
@michael-s-molina michael-s-molina mentioned this pull request Jun 5, 2024
Merged
9 tasks
@hainenber hainenber deleted the remove-unused-react-imports branch June 5, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

Assignees
No one assigned
Labels
change:frontend Requires changing the frontend dependencies:npm doc Namespace | Anything related to documentation packages plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hainenber @michael-s-molina @rusackas