Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48340][PYTHON] Support TimestampNTZ infer schema miss prefer_timestamp_ntz #46666

Closed
wants to merge 1 commit into from

Conversation

AngersZhuuuu
Copy link
Contributor

What changes were proposed in this pull request?

Support TimestampNTZ infer schema miss prefer_timestamp_ntz

Why are the changes needed?

Fix bug

Does this PR introduce any user-facing change?

No

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

No

@AngersZhuuuu
Copy link
Contributor Author

ping @mengxr @HyukjinKwon

@HyukjinKwon HyukjinKwon changed the title [SPARK-48340][PYSPARK] Support TimestampNTZ infer schema miss prefer_timestamp_ntz [SPARK-48340][PYTHON] Support TimestampNTZ infer schema miss prefer_timestamp_ntz May 20, 2024
@HyukjinKwon
Copy link
Member

Merged to master.

@HyukjinKwon
Copy link
Member

Actually @AngersZhuuuu can we add a test?

@HyukjinKwon
Copy link
Member

If spark.sql.timestampType is set to TIMESTAMP_NTZ, and nested Row contains, datetime instance, then it infers as TimestampNTZType after this change. Before this change, TimestampType?

@AngersZhuuuu
Copy link
Contributor Author

If spark.sql.timestampType is set to TIMESTAMP_NTZ, and nested Row contains, datetime instance, then it infers as TimestampNTZType after this change. Before this change, TimestampType?

Yea, doing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants