Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-47508][PYTHON] Update black to 24.3.0 #45647

Closed
wants to merge 1 commit into from

Conversation

bjornjorgensen
Copy link
Contributor

@bjornjorgensen bjornjorgensen commented Mar 21, 2024

What changes were proposed in this pull request?

Update black from 23.9.1 to 24.3.0

Why are the changes needed?

Fix thrue psf/black#4278

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Mar 21, 2024
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you install black==24.3.0 and run it locally, @bjornjorgensen ?

FYI, the PR Builder on this PR is not using 24.3.0.

https://github.com/bjornjorgensen/spark/actions/runs/8376905194/job/22937764245

Please refer for the required change.

#37305

In addition, black is only used in dev/lint-python script against Apache Spark Source Code in GitHub Action CIs. Given that all PRs to the Apache Spark repository are running on the contributors' GitHub Action first. We are not exposed to any ReDoS Attack.

Please remove the invalid CVE info, @bjornjorgensen . It's a false alarm.

@dongjoon-hyun
Copy link
Member

FYI, I closed the same dependabot PR yesterday due to the same reasons.

@bjornjorgensen
Copy link
Contributor Author

ah.. ok.
Thank you @dongjoon-hyun

@bjornjorgensen bjornjorgensen deleted the black24.3.0 branch March 21, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants