-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-47234][BUILD] Upgrade Scala to 2.13.13 #45342
Conversation
From GA testing, it seems that A PR has been submitted to the upstream |
Thank you, @panbingkun ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, according to the release note, we need to upgrade SBT too.
Users of sbt must upgrade to sbt 1.9.9 to use the console task to access the 2.13.13 REPL (sbt/sbt#7502); error message is NoSuchMethodError: org.jline.utils.AttributedString.fromAnsi
I also saw your SBT 1.9.9 test PR and its failure.
In the worst case, we cannot upgrade to Scala 2.13.13.
Yes, but unfortunately, from the test results of another PR, it seems that |
Yes, that's what I meant exactly. Scala 2.13.13 requires SBT 1.9.9 but SBT 1.9.9 is not working properly. In short, there is no working combination in Scala 2.13.13 and this is the worst case where we are currently standing. I don't know if SBT 1.9.10 might solve every issues, but it's also unlikely.
|
I have already submitted a bug report to SBT: sbt/sbt#7506 But it seems to be a problem with the coursier . cc @LuciferYang |
In fact, com-lihaoyi/Ammonite#1421 is already in the process of upgrading, there are probably some tests that have not passed yet |
Thank you for updates for both. |
It seems that 3.0.0-M1 is released last week. Could you rebase the PR? I guess the only remaining issue is SBT? |
Okay, let me try it. Thanks for reminding me. ❤️ |
@@ -226,7 +226,7 @@ | |||
./python/pyspark/sql/pandas/utils.py, and ./python/setup.py too. | |||
--> | |||
<arrow.version>15.0.0</arrow.version> | |||
<ammonite.version>2.5.11</ammonite.version> | |||
<ammonite.version>3.0.0-M1</ammonite.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the dependency list? The other tests seem to pass.
+++ b/dev/pr-deps/spark-deps-hadoop-3-hive-2.3
@@ -139,7 +139,7 @@ jettison/1.5.4//jettison-1.5.4.jar
jetty-util-ajax/11.0.20//jetty-util-ajax-11.0.20.jar
jetty-util/11.0.20//jetty-util-11.0.20.jar
jline/2.14.6//jline-2.14.6.jar
-jline/3.22.0//jline-3.22.0.jar
+jline/3.24.1//jline-3.24.1.jar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, it seems that we have two jline libraries at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me analyze it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll see what
depends on them. If they can be aligned
, it would be great if only one
is left.
Of course, that's another issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/apache/hive/blob/36b32612ba0a20d3d305c77a813aca62d7129ed0/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java#L41-L49
From the hive 2.3 version
code, it seems that we cannot
align here because its import
of jline
starts with jline....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try in SPARK-47405 independently in the scope of upgrading spark-sql
shell to use jline3
. If it's difficult, we can live with this as you confirmed that they are different packages now.
If CI passed, shall we land this to |
I agree with you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @panbingkun and @LuciferYang .
Merged to master for Apache Spark 4.0.0.
### What changes were proposed in this pull request? The pr aims to upgrade scala from `2.13.12` to `2.13.13`. ### Why are the changes needed? - The new version bring some bug fixes: scala/scala#10525 scala/scala#10528 - The release notes as follows: https://github.com/scala/scala/releases/tag/v2.13.13 ### Does this PR introduce _any_ user-facing change? Yes, The `scala` version is changed from `2.13.12` to `2.13.13`. ### How was this patch tested? - Pass GA. - After the master is upgraded to this version `2.13.13`, we need to continue to observe. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45342 from panbingkun/SPARK-47234. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
What changes were proposed in this pull request?
The pr aims to upgrade scala from
2.13.12
to2.13.13
.Why are the changes needed?
The new version bring some bug fixes:
fix: SliceIterator to drop a max of Int.MaxValue scala/scala#10525
Fixes issue with blocking and BatchingExecutor scala/scala#10528
The release notes as follows: https://github.com/scala/scala/releases/tag/v2.13.13
Does this PR introduce any user-facing change?
Yes, The
scala
version is changed from2.13.12
to2.13.13
.How was this patch tested?
2.13.13
, we need to continue to observe.Was this patch authored or co-authored using generative AI tooling?
No.