Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: not ignore *.txt to make sure files like CMakeLists.txt can be checked #141

Merged
merged 3 commits into from Sep 27, 2022
Merged

fix: not ignore *.txt to make sure files like CMakeLists.txt can be checked #141

merged 3 commits into from Sep 27, 2022

Conversation

acelyc111
Copy link
Member

No description provided.

kezhenxu94
kezhenxu94 approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be a minor breaking changes, but users can easily add txt to their ignore path so this LGTM

@kezhenxu94 kezhenxu94 merged commit da0aa5d into apache:main Sep 27, 2022
@krassowski krassowski mentioned this pull request Sep 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@acelyc111 @kezhenxu94