Fix exclude not work for transitive dependencies and add recursive config #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhenxu94
added
bug
kezhenxu94
commented
Sep 8, 2022
| # - package.json # If this is a npm project. | ||
| # - go.mod # If this is a Go project. | ||
| # If you don't want to check dependencies' license compatibility, remove the following part | ||
| dependency: |
There was a problem hiding this comment.
Previously when users uncomment the the codes they might make the indentation wrong, so I uncomment these by default and users can opt-out by deleting them
kezhenxu94
commented
Sep 8, 2022
| github.com/pascaldekloe/goe | ||
| github.com/russross/blackfriday/v2 | ||
| gopkg.in/check.v1 | ||
| INFO Loading configuration from file: .licenserc.yaml |
There was a problem hiding this comment.
Now that we improve the correctness, I update the example to reflect that.
kezhenxu94
force-pushed
the
bug/exclude
branch
from
5274939
to
1e93e3a
Compare
kezhenxu94
force-pushed
the
bug/exclude
branch
from
1e93e3a
to
d8bed6e
Compare
wu-sheng
approved these changes
Sep 8, 2022
|
@kezhenxu94 test has passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependency.excludesdoesn't work for transitive dependencies so this might bring some dependencies that users want to exclude.This patch also adds a
recursiveconfig so users can decide whether to only exclude one dependency or also exclude all dependencies brought by this dependency./cc @jmjoy currently it seems Rust (cargo.go) only resolve direct dependencies, not including transitive dependencies, so we might miss some transitive dependencies in the license report.
/cc and thanks to @slievrly for reporting this bug