Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optional dependencies are not excluded #136

Merged
merged 1 commit into from Sep 7, 2022
Merged

Fix optional dependencies are not excluded #136

merged 1 commit into from Sep 7, 2022

Conversation

kezhenxu94
Copy link
Member

Optional dependencies should be excluded but they are not because of regexp missing the optional part

[INFO] +- org.mariadb.jdbc:mariadb-java-client:jar:2.7.2:provided (optional)

@kezhenxu94 kezhenxu94 added bug Something isn't working dep / maven Dependency command, maven project labels Sep 7, 2022
@kezhenxu94 kezhenxu94 added this to the 0.5.0 milestone Sep 7, 2022
@kezhenxu94 kezhenxu94 merged commit 25edfc2 into main Sep 7, 2022
@kezhenxu94 kezhenxu94 deleted the maven/optional branch September 7, 2022 15:06
@slievrly
Copy link
Member

slievrly commented Sep 8, 2022

@kezhenxu94 get the latest code, make build, and the test case passes.

@slievrly slievrly mentioned this pull request Sep 8, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgksgf fgksgf fgksgf approved these changes

@wu-sheng wu-sheng Awaiting requested review from wu-sheng

Assignees
No one assigned
Labels
bug Something isn't working dep / maven Dependency command, maven project
Projects
None yet
Milestone
0.5.0
3 participants
@kezhenxu94 @slievrly @fgksgf