-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][Zeta] Move SaveMode behavior to master #6843
base: dev
Are you sure you want to change the base?
Conversation
for (LogicalEdge edge : edges) { | ||
out.writeObject(edge); | ||
} | ||
|
||
out.writeInt(saveModeList.size()); | ||
for (SupportSaveMode saveMode : saveModeList) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider the DataSerializable of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, the current SupportSaveMode declarations are all on the SeaTunnelSink implementation class, and all SeaTunnelSinks are serializable by default. It is also engine-independent.
aeaa2e0
to
a7c04b7
Compare
package org.apache.seatunnel.api.sink; | ||
|
||
public enum SaveModeExecuteLocation { | ||
CLIENT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mark it as obsolete for possible future removal?
@@ -33,6 +33,10 @@ This parameter configures the parallelism of source and sink. | |||
|
|||
Used to control the default retry times when a job fails. The default value is 3, and it only works in the Zeta engine. | |||
|
|||
### savemode.execute.location | |||
|
|||
This parameter is used to specify the location of the savemode when the job is executed in the Zeta engine. The default value is `CLUSTER`, which means that the savemode is executed on the cluster. If you want to execute the savemode on the client, you can set it to `CLIENT`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLIENT
Mark it as obsolete for possible future removal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.getName() | ||
.equals( | ||
"org.apache.seatunnel.connectors.seatunnel.common.multitablesink.MultiTableSink")) { | ||
// TODO we should not use class name to judge the sink type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explain the detailed reason. I see that it is possible to implement SaveModeHandler
Purpose of this pull request
This PR move savemode logic into master node.
Mainly for two purposes:
Does this PR introduce any user-facing change?
no
How was this patch tested?
add new test.
Check list
New License Guide
release-note
.