Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix]Fix available permits in MessageReceived #1181

Merged
merged 4 commits into from Feb 23, 2024

Conversation

panszobe
Copy link
Contributor

@panszobe panszobe commented Feb 23, 2024

Fixes #1180

Motivation

In the MessageReceived, the number of skipped messages should be increased to available permits to avoid skipped permits leading flow request not be sent.

@lhotari
Copy link
Member

lhotari commented Feb 23, 2024

@panszobe Good catch! Thanks for the contribution.

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobertIndie RobertIndie added this to the v0.13.0 milestone Feb 23, 2024
@RobertIndie RobertIndie merged commit 5d25827 into apache:master Feb 23, 2024
8 checks passed
RobertIndie pushed a commit that referenced this pull request Feb 29, 2024
Fixes #1180

### Motivation
In the `MessageReceived`, the number of skipped messages should be increased to available permits to avoid skipped permits leading flow request not be sent.
---------

Co-authored-by: panjinjun <1619-panjinjun@users.noreply.git.sysop.bigo.sg>
(cherry picked from commit 5d25827)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants