Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [issue 1067] Fix the excessive dataChan capacity #1068

Closed
wants to merge 1 commit into from

Conversation

Gleiphir2769
Copy link
Contributor

Fixes #1067

Motivation

wait to edit...

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

@gunli
Copy link
Contributor

gunli commented Jul 22, 2023

Hi @Gleiphir2769, as discussed in #1055 , we will move some logic from internalSend() back to internalAsyncSend(), reserving resource for the requset will be done before putting it into dataChan, if there is enough semaphore and pending queue spaces, continue, or it will be block or failed, as the JAVA client did, and this won't be a problem any more.

@Gleiphir2769
Copy link
Contributor Author

we will move some logic from internalSend() back to internalAsyncSend(), reserving resource for the requset will be done before putting it into dataChan

If we have made some progress in this work, this PR can be closed. But I think we should fix the existing bugs first and this fix has no side effects on this work. What do you think? @gunli

@gunli
Copy link
Contributor

gunli commented Jul 24, 2023

If we have made some progress in this work, this PR can be closed. But I think we should fix the existing bugs first and this fix has no side effects on this work. What do you think? @gunli

@Gleiphir2769 I will do the refactoring work this week.

@Gleiphir2769
Copy link
Contributor Author

Gleiphir2769 commented Jul 25, 2023

I will do the refactoring work this week.

Good @gunli ! I will close this PR after your refactor work.

@gunli
Copy link
Contributor

gunli commented Jul 25, 2023

@Gleiphir2769 I have pushed the PR #1071 , please help to review it, thanks!

@tisonkun
Copy link
Member

Closing...

You may review #1121 and I still think that we can have a much better solution than even after #1121 merged.

@tisonkun tisonkun closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The capacity of dataChan is too big
3 participants