Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] improve the perf of schema and schema cache #1033

Merged
merged 6 commits into from Jul 4, 2023

Conversation

gunli
Copy link
Contributor

@gunli gunli commented Jun 25, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

Master Issue: #

Motivation

SchemaInfo.hash() and schemaCache.Get() are frequently called by partitionProducer.internalSend(), current implementation of these functions use sync.RWMutex to sync the cache map and calculate the hash every call, use the sync.Map and cache the hash value can improve the performance.

Modifications

Describe the modifications you've done.

  • Modified: pulsar/producer_partition.go
  • Modified: pulsar/schema.go

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (yes / no)
  • The schema: (yes)
  • The default values of configurations: (no)
  • The wire protocol: ( no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Member

@shibd shibd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Left some small comments.

pulsar/schema.go Outdated Show resolved Hide resolved
pulsar/schema.go Outdated Show resolved Hide resolved
@shibd shibd merged commit 163cd7e into apache:master Jul 4, 2023
6 checks passed
@RobertIndie RobertIndie modified the milestones: v0.11.0, v0.12.0 Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants