Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Scala version to 2.13.13 & 2.12.19 #1160

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Feb 28, 2024

Motivation:
Bump Scala version on 1.0.x branch

@raboof
Copy link
Member

raboof commented Feb 28, 2024

is there a particular reason to backport these updates? do they fix any serious bugs?

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed, so approving

@He-Pin He-Pin added this to the 1.0.x milestone Feb 28, 2024
@He-Pin He-Pin merged commit 2f4be46 into apache:1.0.x Feb 28, 2024
18 checks passed
@He-Pin He-Pin deleted the bumpScala branch February 28, 2024 08:24
@pjfanning
Copy link
Contributor

I don't think this should have been merged. Generally, we don't backport jar upgrade PRs. Specifically, with this PR, it includes compiler setting changes.

@He-Pin
Copy link
Member Author

He-Pin commented Feb 28, 2024

The new Scala version can help us keep source compatibility when doing backporting,eg:
Support binary integer literals using 0b, as in Java
In mixed compilation, allow Java sources to reference MODULE$

But yes, the future update will need a vote on maillist first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants