GH-3172: Do not drop blocks with some null values if DictionaryFilter is applied for UserDefinedPredicate which keeps null values
#3173
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `UserDefinedPredicate` which keeps null values
|
Thanks for the fix! I think it looks good. cc @gszadovszky |
|
Fixed formatting. |
gszadovszky
approved these changes
Mar 13, 2025
wgtmac
approved these changes
Mar 13, 2025
wgtmac
changed the title
DictionaryFilter is applied for UserDefinedPredicate which keeps null valuesDictionaryFilter is applied for UserDefinedPredicate which keeps null values
wgtmac
pushed a commit
that referenced
this pull request
Mar 13, 2025
…r` is applied for `UserDefinedPredicate` which keeps null values (#3173)
|
Thanks @ebartkus and @gszadovszky! I've backported it: 9d6e19f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix for #3172
What changes are included in this PR?
Adding an explicit check for the existence of null values in the block if 'UserDefinedPredicate' accepts nulls. If null values exist and the predicate accepts nulls, the block cannot be dropped.
Are these changes tested?
Yes, a new test was created.
Are there any user-facing changes?
No.
Closes #3172