ORC-1550: Upgrade Maven to 3.9.6
#1687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
force-pushed
the
ORC-1550
branch
from
be366f9
to
5663d88
Compare
This was referenced Dec 9, 2023
dongjoon-hyun
pushed a commit
to apache/orc-format
that referenced
this pull request
Dec 9, 2023
### What changes were proposed in this pull request? This closes #10. The PR aims at upgrading Maven version to 3.9.6 ### Why are the changes needed? The details are captured as part of PR apache/orc#1687 ### How was this patch tested? Local build to be successful and CI passes
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This PR aims to upgrade `Apache Maven` to 3.9.6. ### Why are the changes needed? Apache Maven 3.9.6 has MNG-7913 to improve Java supports. Although it's only for up to Java 19, this is better than the previous condition (up to Java 14). - apache/maven#1286 > To version that supports gleaning JSR330 component classes up to Java 19. The reasoning of this change is only to allow 3rd party Maven plugins/Maven extensions/other JSR330 components (managed by Maven embedded Sisu) to use bytecode newer that Java 14 (Sisu 0.3.5). In addition, Maven 3.9.4 hits IOError like the following on Ubuntu 24.04. ``` root479e66773188:/orc/java# ./mvnw --version Exception in thread "main" java.io.IOError: java.io.IOException: Broken pipe at org.fusesource.jansi.AnsiConsole.systemUninstall(AnsiConsole.java:544) at org.apache.maven.shared.utils.logging.MessageUtils.doSystemUninstall(MessageUtils.java:101) at org.apache.maven.shared.utils.logging.MessageUtils.systemUninstall(MessageUtils.java:80) at org.apache.maven.cli.MavenCli.main(MavenCli.java:197) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) at java.base/java.lang.reflect.Method.invoke(Method.java:580) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:283) at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:226) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:407) at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:348) Caused by: java.io.IOException: Broken pipe at java.base/java.io.FileOutputStream.writeBytes(Native Method) at java.base/java.io.FileOutputStream.write(FileOutputStream.java:367) at org.fusesource.jansi.io.FastBufferedOutputStream.flushBuffer(FastBufferedOutputStream.java:58) at org.fusesource.jansi.io.FastBufferedOutputStream.flush(FastBufferedOutputStream.java:65) at java.base/java.io.FilterOutputStream.flush(FilterOutputStream.java:155) at org.fusesource.jansi.io.AnsiOutputStream.uninstall(AnsiOutputStream.java:338) at org.fusesource.jansi.AnsiPrintStream.uninstall(AnsiPrintStream.java:82) at org.fusesource.jansi.AnsiConsole.systemUninstall(AnsiConsole.java:541) ... 9 more Using `mvn` from path: /orc/java/build/apache-maven-3.9.4/bin/mvn ``` This is fixed at Maven 3.9.5+. ``` root479e66773188:/orc/java# ./mvnw --version exec: curl --silent --show-error -L https://www.apache.org/dyn/closer.lua?action=download&filename=/maven/maven-3/3.9.5/binaries/apache-maven-3.9.5-bin.tar.gz Using `mvn` from path: /orc/java/build/apache-maven-3.9.5/bin/mvn Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546) Maven home: /orc/java/build/apache-maven-3.9.5 Java version: 21.0.1, vendor: Private Build, runtime: /usr/lib/jvm/java-21-openjdk-arm64 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "6.4.16-linuxkit", arch: "aarch64", family: "unix" ``` ### How was this patch tested? Pass the CIs. Closes apache#1687 from dongjoon-hyun/ORC-1550. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade
Apache Mavento 3.9.6.Why are the changes needed?
Apache Maven 3.9.6 has MNG-7913 to improve Java supports. Although it's only for up to Java 19, this is better than the previous condition (up to Java 14).
In addition, Maven 3.9.4 hits IOError like the following on Ubuntu 24.04.
This is fixed at Maven 3.9.5+.
How was this patch tested?
Pass the CIs.