Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(service/redis): Add docker-compose file to simplicy the CI #2864

Closed

Conversation

Zheaoli
Copy link
Member

@Zheaoli Zheaoli commented Aug 14, 2023

No description provided.

Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
@suyanhanx
Copy link
Member

Could you please put the docker compose file like this PR #2858 ?

@Zheaoli
Copy link
Member Author

Zheaoli commented Aug 14, 2023

Could you please put the docker compose file like this PR #2858 ?

I don't think the docker compose file in the fixture directory is a good idea.

Normally, the misc file like dockerfile for developer, util script will be put into a split directory. FYI https://github.com/apache/zookeeper/tree/master/dev/docker
https://github.com/blockscout/blockscout/tree/master/docker-compose

@Xuanwo
Copy link
Member

Xuanwo commented Aug 15, 2023

Thanks for the PR, but this PR's work has been covered by #2858


# Create CA

openssl req \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the idea to generate crt everytime. Our developer may don't have the enviorment to do this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zheaoli Zheaoli closed this Aug 15, 2023
@Zheaoli Zheaoli deleted the manjusaka/add-redis-docker-compose-for-ci branch August 15, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants