Skip to content

Expand JDK toolchain docs #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 29, 2024
Merged

Expand JDK toolchain docs #18

merged 3 commits into from
Feb 29, 2024
+39 −19

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Feb 25, 2024

@elharo
RewriteJDK toolchain docs

Verified

This commit was signed with the committer’s verified signature.
RobinMalfait Robin Malfait
SSH Key Fingerprint: z0P0cbdWrGAdlumUhndHMdMgBOP5B0N+e5c54QYlkn8
Verified
Learn about vigilant mode
9d0a65a 
@slawekjaranowski
@elharo elharo requested a review from khmarbaise February 25, 2024 14:40
@elharo elharo changed the title RewriteJDK toolchain docs Rewrite JDK toolchain docs Feb 25, 2024
@slawekjaranowski
Copy link
Member

We need parent at version 41

gnodet and others added 2 commits February 28, 2024 13:30
@gnodet
Merge remote-tracking branch 'origin/master' into elharo-patch-1

Verified

This commit was signed with the committer’s verified signature.
RobinMalfait Robin Malfait
SSH Key Fingerprint: z0P0cbdWrGAdlumUhndHMdMgBOP5B0N+e5c54QYlkn8
Verified
Learn about vigilant mode
56e3643
@elharo
typos

Verified

This commit was signed with the committer’s verified signature.
RobinMalfait Robin Malfait
SSH Key Fingerprint: z0P0cbdWrGAdlumUhndHMdMgBOP5B0N+e5c54QYlkn8
Verified
Learn about vigilant mode
fe47775
@elharo elharo changed the title Rewrite JDK toolchain docs Expand JDK toolchain docs Feb 28, 2024
@elharo
Copy link
Contributor Author

elharo commented Feb 28, 2024

PTAL. parent is updated and all tests pass

hboutemy
hboutemy approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@hboutemy hboutemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement, thanks

@elharo elharo merged commit 05c6ae6 into master Feb 29, 2024
@elharo elharo deleted the elharo-patch-1 branch February 29, 2024 13:04
hboutemy added a commit that referenced this pull request Mar 2, 2024
@hboutemy
fix apt format #18

Verified

This commit was signed with the committer’s verified signature.
RobinMalfait Robin Malfait
SSH Key Fingerprint: z0P0cbdWrGAdlumUhndHMdMgBOP5B0N+e5c54QYlkn8
Verified
Learn about vigilant mode
8508a51
@olamy olamy added the documentation Improvements or additions to documentation label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hboutemy hboutemy

@khmarbaise khmarbaise

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@elharo @slawekjaranowski @hboutemy @olamy @gnodet