Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUREFIRE-2223] Surefire evaluates parameter jvm before skip #703

Merged
merged 1 commit into from Dec 23, 2023
+5 −4
Merged

[SUREFIRE-2223] Surefire evaluates parameter jvm before skip #703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
View file
Open in desktop
Expand Up @@ -876,6 +876,11 @@ private String getDefaultExcludes() {

@Override
public void execute() throws MojoExecutionException, MojoFailureException {
if (isSkipExecution()) {
getConsoleLogger().info("Tests are skipped.");
return;
}

cli = commandLineOptions();
// Stuff that should have been final
setupStuff();
Expand Down Expand Up @@ -1030,10 +1035,6 @@ DefaultScanResult scanDependencies() throws MojoFailureException {

boolean verifyParameters() throws MojoFailureException, MojoExecutionException {
setProperties(new SurefireProperties(getProperties()));
if (isSkipExecution()) {
getConsoleLogger().info("Tests are skipped.");
return false;
}

String jvmToUse = getJvm();
if (toolchain != null) {
Expand Down