Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2221] Document minimum supported Java version for Toolchains #701

Merged
merged 1 commit into from Dec 13, 2023

Conversation

@sbernard31
Copy link
Contributor Author

I hope I've understood the syntax of the documentation correctly.

Note that I didn't check if this generates the web site properly.

Also I tried to search minimal java version requirement for older surefire version. I think this would be a useful information but didn't find any easy way to get that.

@michael-o michael-o changed the title [SUREFIRE-1923] Add documentation about minimal java version usable with toolchain [SUREFIRE-2221] Document minimum supported Java version for Toolchains Dec 13, 2023
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Looks good to me now. Will handle squash and merge.

@sbernard31
Copy link
Contributor Author

Thanks for your contribution. Looks good to me now. Will handle squash and merge.

Thx 🙏 for taking time to answer to questions and maintaining this useful piece of software.

(Keep in mind that I didn't test if this will generate web site correctly)

@asfgit asfgit merged commit 8676714 into apache:master Dec 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants