Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-1124] Support forkNumber in environment variables #664

Merged
merged 1 commit into from Aug 31, 2023

Conversation

swismer
Copy link

@swismer swismer commented Jun 19, 2023

Implementation for https://issues.apache.org/jira/browse/SUREFIRE-1124 including test and documentation updates. I also changed "place holder" to "placeholder" in the related documentation section as this is the common way to write it.

Thank you for having a look at this PR!

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

@michael-o michael-o changed the title [SUREFIRE-2124] Support forkNumber in environment variables [SUREFIRE-1124] Support forkNumber in environment variables Jun 21, 2023
@slawekjaranowski
Copy link
Member

Please add at least

hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

to PR description from standard PR template.

@slawekjaranowski
Copy link
Member

@swismer please check build output .... and fix according

@swismer swismer force-pushed the SUREFIRE-1124 branch 2 times, most recently from 8762f49 to 78c3e38 Compare July 13, 2023 19:03
@swismer
Copy link
Author

swismer commented Jul 13, 2023

Sorry, I fixed the formatting and the mistyped JIRA ticket number in the commit message. In addition, the documentation now states the version required to use this new feature. I will probably have to change that, once it is known which release it will be part of.

@slawekjaranowski
Copy link
Member

Next version will be 3.2.0 and I hope this PR will be part in it.

@swismer
Copy link
Author

swismer commented Jul 14, 2023

I updated the version in the documentation to 3.2.0. I hope that the Java 8 build failure is only a temporary glitch...

@slawekjaranowski slawekjaranowski merged commit 9b79bda into apache:master Aug 31, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants