Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUREFIRE-2177] Use junit-bom instead of single JUnit 5 versions #663

Merged
merged 1 commit into from Jul 14, 2023
Merged

[SUREFIRE-2177] Use junit-bom instead of single JUnit 5 versions #663

merged 1 commit into from Jul 14, 2023

Conversation

scordio
Copy link
Contributor

@scordio scordio commented Jun 9, 2023 •
edited

@scordio scordio marked this pull request as ready for review June 9, 2023 07:45
@scordio scordio changed the title [SUREFIRE-2177] Favor junit-bom instead of single JUnit 5 versions [SUREFIRE-2177] Use junit-bom instead of single JUnit 5 versions Jun 9, 2023
@scordio
Copy link
Contributor Author

scordio commented Jun 9, 2023

As far as I can judge, the two failing jobs don't seem to be related to my changes, but let me know in case I should look into something.

michael-o
michael-o approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement

@slawekjaranowski slawekjaranowski merged commit 27548ec into apache:master Jul 14, 2023
13 checks passed
@scordio scordio deleted the junit-bom branch July 14, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy olamy approved these changes

@michael-o michael-o michael-o approved these changes

@slachiewicz slachiewicz slachiewicz approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
5 participants
@scordio @olamy @michael-o @slachiewicz @slawekjaranowski