Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2166] Use ChoiceFormat to selective render percentage and elapsed time in SurefireReportRenderer #639

Merged
merged 1 commit into from May 28, 2023

Conversation

michael-o
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@asfgit asfgit force-pushed the improve-formatted-time-and-percentage-in-report branch from 56ffa9e to 5fd828b Compare May 24, 2023 14:02
asfgit pushed a commit that referenced this pull request May 24, 2023
…lapsed time in SurefireReportRenderer

This closes #639
@asfgit asfgit force-pushed the improve-formatted-time-and-percentage-in-report branch from 5fd828b to 845c9c5 Compare May 24, 2023 19:28
@michael-o michael-o changed the title Use choice message format to render percentage and time [SUREFIRE-2166] Use ChoiceFormat to selective render percentage and elapsed time in SurefireReportRenderer May 24, 2023
@michael-o michael-o marked this pull request as ready for review May 24, 2023 19:29
asfgit pushed a commit that referenced this pull request May 24, 2023
…lapsed time in SurefireReportRenderer

This closes #639
@asfgit asfgit force-pushed the improve-formatted-time-and-percentage-in-report branch from 845c9c5 to c1d74e5 Compare May 24, 2023 19:40
asfgit pushed a commit that referenced this pull request May 25, 2023
…lapsed time in SurefireReportRenderer

This closes #639
@asfgit asfgit force-pushed the improve-formatted-time-and-percentage-in-report branch from c1d74e5 to bc5bf78 Compare May 25, 2023 05:34
asfgit pushed a commit that referenced this pull request May 25, 2023
…lapsed time in SurefireReportRenderer

This closes #639
asfgit pushed a commit that referenced this pull request May 25, 2023
…lapsed time in SurefireReportRenderer

This closes #639
@asfgit asfgit force-pushed the improve-formatted-time-and-percentage-in-report branch from bc5bf78 to e5af74c Compare May 25, 2023 06:58
asfgit pushed a commit that referenced this pull request May 25, 2023
…lapsed time in SurefireReportRenderer

This closes #639
asfgit pushed a commit that referenced this pull request May 25, 2023
… elapsed time in SurefireReportRenderer

This closes #639
@asfgit asfgit force-pushed the improve-formatted-time-and-percentage-in-report branch from e5af74c to 1e23681 Compare May 25, 2023 09:12
asfgit pushed a commit that referenced this pull request May 25, 2023
… elapsed time in SurefireReportRenderer

This closes #639
Copy link
Member

@hboutemy hboutemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

… elapsed time in SurefireReportRenderer

This closes #639
@asfgit asfgit force-pushed the improve-formatted-time-and-percentage-in-report branch from 1e23681 to 2967be3 Compare May 28, 2023 09:47
@asfgit asfgit closed this in 2967be3 May 28, 2023
@asfgit asfgit merged commit 2967be3 into master May 28, 2023
3 of 10 checks passed
@michael-o michael-o deleted the improve-formatted-time-and-percentage-in-report branch May 28, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants