New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SUREFIRE-2166] Use ChoiceFormat to selective render percentage and elapsed time in SurefireReportRenderer #639
Merged
asfgit
merged 1 commit into
master
from
improve-formatted-time-and-percentage-in-report
May 28, 2023
Merged
[SUREFIRE-2166] Use ChoiceFormat to selective render percentage and elapsed time in SurefireReportRenderer #639
asfgit
merged 1 commit into
master
from
improve-formatted-time-and-percentage-in-report
May 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asfgit
force-pushed
the
improve-formatted-time-and-percentage-in-report
branch
from
May 24, 2023 14:02
56ffa9e
to
5fd828b
Compare
asfgit
pushed a commit
that referenced
this pull request
May 24, 2023
…lapsed time in SurefireReportRenderer This closes #639
asfgit
force-pushed
the
improve-formatted-time-and-percentage-in-report
branch
from
May 24, 2023 19:28
5fd828b
to
845c9c5
Compare
michael-o
changed the title
Use choice message format to render percentage and time
[SUREFIRE-2166] Use ChoiceFormat to selective render percentage and elapsed time in SurefireReportRenderer
May 24, 2023
asfgit
pushed a commit
that referenced
this pull request
May 24, 2023
…lapsed time in SurefireReportRenderer This closes #639
asfgit
force-pushed
the
improve-formatted-time-and-percentage-in-report
branch
from
May 24, 2023 19:40
845c9c5
to
c1d74e5
Compare
asfgit
pushed a commit
that referenced
this pull request
May 25, 2023
…lapsed time in SurefireReportRenderer This closes #639
asfgit
force-pushed
the
improve-formatted-time-and-percentage-in-report
branch
from
May 25, 2023 05:34
c1d74e5
to
bc5bf78
Compare
asfgit
pushed a commit
that referenced
this pull request
May 25, 2023
…lapsed time in SurefireReportRenderer This closes #639
asfgit
pushed a commit
that referenced
this pull request
May 25, 2023
…lapsed time in SurefireReportRenderer This closes #639
asfgit
force-pushed
the
improve-formatted-time-and-percentage-in-report
branch
from
May 25, 2023 06:58
bc5bf78
to
e5af74c
Compare
asfgit
pushed a commit
that referenced
this pull request
May 25, 2023
…lapsed time in SurefireReportRenderer This closes #639
asfgit
pushed a commit
that referenced
this pull request
May 25, 2023
… elapsed time in SurefireReportRenderer This closes #639
asfgit
force-pushed
the
improve-formatted-time-and-percentage-in-report
branch
from
May 25, 2023 09:12
e5af74c
to
1e23681
Compare
asfgit
pushed a commit
that referenced
this pull request
May 25, 2023
… elapsed time in SurefireReportRenderer This closes #639
slawekjaranowski
approved these changes
May 26, 2023
hboutemy
approved these changes
May 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… elapsed time in SurefireReportRenderer This closes #639
asfgit
force-pushed
the
improve-formatted-time-and-percentage-in-report
branch
from
May 28, 2023 09:47
1e23681
to
2967be3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
SUREFIRE-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean install
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.