Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2146] Don't draw border around reporting tables #596

Merged
merged 1 commit into from
Feb 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ private void constructSummarySection( LocalizedProperties bundle, Sink sink )

sink.table();

sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, true );
sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, false );

sink.tableRow();

Expand Down Expand Up @@ -196,7 +196,7 @@ private void constructPackagesSection( LocalizedProperties bundle, Sink sink,

sink.table();

sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, true );
sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, false );

sink.tableRow();

Expand Down Expand Up @@ -281,7 +281,7 @@ private void constructPackagesSection( LocalizedProperties bundle, Sink sink,
{
sink.table();

sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, true );
sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, false );

sink.tableRow();

Expand Down Expand Up @@ -412,7 +412,7 @@ private void constructTestCasesSection( LocalizedProperties bundle, Sink sink )
{
sink.table();

sink.tableRows( new int[]{ LEFT, LEFT, LEFT }, true );
sink.tableRows( new int[]{ LEFT, LEFT, LEFT }, false );

for ( ReportTestCase testCase : testCases )
{
Expand Down Expand Up @@ -555,7 +555,7 @@ private void constructFailureDetails( Sink sink, LocalizedProperties bundle, Lis

sink.table();

sink.tableRows( new int[]{ LEFT, LEFT }, true );
sink.tableRows( new int[]{ LEFT, LEFT }, false );

for ( ReportTestCase tCase : failures )
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public void testCorruptedTestCaseFailureWithMissingErrorTypeAndMessage()
gen.doGenerateReport( new SurefireReportMojo().getBundle( ENGLISH ), sink );
String xml = writer.toString();
assertThat( xml, containsString( toSystemNewLine(
"<table border=\"1\" class=\"bodyTable\">\n"
"<table border=\"0\" class=\"bodyTable\">\n"
+ "<tr class=\"a\">\n"
+ "<th>Tests</th>\n"
+ "<th>Errors</th>\n"
Expand All @@ -72,7 +72,7 @@ public void testCorruptedTestCaseFailureWithMissingErrorTypeAndMessage()
+ "</tr>"
+ "</table>" ) ) );
assertThat( xml, containsString( toSystemNewLine(
"<table border=\"1\" class=\"bodyTable\">\n"
"<table border=\"0\" class=\"bodyTable\">\n"
+ "<tr class=\"a\">\n"
+ "<th>Package</th>\n"
+ "<th>Tests</th>\n"
Expand All @@ -90,7 +90,7 @@ public void testCorruptedTestCaseFailureWithMissingErrorTypeAndMessage()
+ "<td align=\"left\">0%</td>\n"
+ "<td align=\"left\">0</td></tr></table>" ) ) );
assertThat( xml, containsString( toSystemNewLine(
"<table border=\"1\" class=\"bodyTable\">\n"
"<table border=\"0\" class=\"bodyTable\">\n"
+ "<tr class=\"a\">\n"
+ "<th></th>\n"
+ "<th>Class</th>\n"
Expand All @@ -110,7 +110,7 @@ public void testCorruptedTestCaseFailureWithMissingErrorTypeAndMessage()
+ "<td align=\"left\">0%</td>\n"
+ "<td align=\"left\">0</td></tr></table>" ) ) );
assertThat( xml, containsString( toSystemNewLine(
"<table border=\"1\" class=\"bodyTable\">\n"
"<table border=\"0\" class=\"bodyTable\">\n"
+ "<tr class=\"a\">\n"
+ "<td align=\"left\"><figure><img src=\"images/icon_error_sml.gif\" alt=\"\" /></figure></td>\n"
+ "<td align=\"left\"><a id=\"surefire.MyTest.test\"></a>test</td></tr>\n"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
/**
* Inclusive test patters:<p>
*
* <table cellspacing=0 border=1>
* <table cellspacing=0 border=0>
* <tr>
* <td style=min-width:50px> test</td>
* <td style=min-width:50px></td>
Expand Down Expand Up @@ -178,7 +178,7 @@
* <p>
* Exclusive test patters:<p>
*
* <table cellspacing=0 border=1>
* <table cellspacing=0 border=0>
* <tr>
* <td style=min-width:50px> test</td>
* <td style=min-width:50px></td>
Expand Down