[SUREFIRE-2149] Make all ITs run with Maven 3.9.0

apache · Feb 12, 2023 · 47f51d0 · 47f51d0
1 parent 1f0c261
commit 47f51d0
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/surefire-its/src/test/java/org/apache/maven/surefire/its/fixture/MavenLauncher.java b/surefire-its/src/test/java/org/apache/maven/surefire/its/fixture/MavenLauncher.java
@@ -218,7 +218,8 @@ public MavenLauncher offline()
 
     public MavenLauncher skipClean()
     {
-        writeGoal( "-Dclean.skip=true" );
+        writeGoal( "-Dclean.skip=true" /* for maven-clean-plugin < 3.0 */ );
+        writeGoal( "-Dmaven.clean.skip=true" /* for maven-clean-plugin 3.0+ */ );
         return this;
     }
 

diff --git a/surefire-its/src/test/resources/surefire-946-dummy-dependency/pom.xml b/surefire-its/src/test/resources/surefire-946-dummy-dependency/pom.xml
@@ -34,6 +34,12 @@
                     <classifier>${distinct.classifier}</classifier>
                 </configuration>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-install-plugin</artifactId>
+                <version>2.5.2</version>
+                <!-- Version has to be pinned because of https://issues.apache.org/jira/browse/MINSTALL-151 -->
+            </plugin>
         </plugins>
     </build>
 </project>
diff --git a/surefire-its/src/test/resources/unicode-testnames/pom.xml b/surefire-its/src/test/resources/unicode-testnames/pom.xml
@@ -51,6 +51,15 @@
         <artifactId>maven-surefire-plugin</artifactId>
         <version>${surefire.version}</version>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>3.8.1</version>
+        <!-- Version pinned because version 3.9.0 and higher of the maven-compiler-plugin throw an -->
+        <!-- UnmappableCharacterException when trying to compile the tests in this project -->
+        <!-- This happens only on Windows and only if the Java version is 8 - 17. Not with JDK 19. -->
+        <!-- Further investigation needed to find the cause and a proper fix. -->
+      </plugin>
     </plugins>
   </build>