Simplify condition for nested output/error elements

apache · Dec 21, 2023 · 065cf91 · 065cf91
1 parent 8676714
commit 065cf91
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/...re-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java b/...re-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
@@ -432,7 +432,7 @@ private static void getTestProblems(
             boolean trimStackTrace,
             OutputStream fw,
             String testErrorType,
-            boolean createOutErrElementsInside)
+            boolean enableNestedOutErrElements)
             throws IOException {
         ppw.startElement(testErrorType);
 
@@ -456,21 +456,19 @@ private static void getTestProblems(
             }
         }
 
-        boolean hasNestedElements = createOutErrElementsInside & stackTrace != null;
-
         if (stackTrace != null) {
-            if (hasNestedElements) {
+            if (enableNestedOutErrElements) {
                 ppw.startElement("stackTrace");
             }
 
             extraEscapeElementValue(stackTrace, outputStreamWriter, ppw, fw);
 
-            if (hasNestedElements) {
+            if (enableNestedOutErrElements) {
                 ppw.endElement();
             }
         }
 
-        if (createOutErrElementsInside) {
+        if (enableNestedOutErrElements) {
             createOutErrElements(outputStreamWriter, ppw, report, fw);
         }