[MSHARED-1107] Make copyFile succeed with source file having #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
force-pushed
the
bugfix/fix-check-for-last-modified-date
branch
from
45d4695
to
03ceba0
Compare
|
Is NIO2 prone to this error? If not, why not use the |
|
NIO2 would throw a proper exception when checking last modified date on a non existing file, but that wouldn't help here either. So an existence check is necessary even when using NIO2 for modified date. |
…fied() = 0 Also check for existence of destination file before overwriting. This closes apache#105
michael-o
force-pushed
the
bugfix/fix-check-for-last-modified-date
branch
from
03ceba0
to
5b78029
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lastModified() = 0
Also check for existence of destination file