Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update overlapping resources warning #171

Merged
merged 1 commit into from Jan 9, 2023
Merged

Update overlapping resources warning #171

merged 1 commit into from Jan 9, 2023

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo marked this pull request as ready for review December 30, 2022 14:39
rmannibucau
rmannibucau approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@rmannibucau rmannibucau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(thinking out loud: maybe we can just use "file" instead of "class or resource")

@pzygielo pzygielo marked this pull request as draft December 30, 2022 15:26
@pzygielo
Copy link
Contributor Author

Thanks for checking. Probably just "file" would be even better indeed!

@pzygielo pzygielo marked this pull request as ready for review December 30, 2022 15:53
@pzygielo

This comment was marked as resolved.

Sign in to view
@slachiewicz slachiewicz merged commit 45b8bbf into apache:master Jan 9, 2023
@pzygielo pzygielo deleted the warning branch January 9, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmannibucau rmannibucau rmannibucau approved these changes

@slachiewicz slachiewicz slachiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@pzygielo @rmannibucau @slachiewicz