Skip to content

Commit

Permalink
[MSHADE-447] Do not use forked guice, use sisu from parent (#188)
Browse files Browse the repository at this point in the history
Use proper Guice, same as Maven. Drop sisu plugin, is defined in parent.

---

https://issues.apache.org/jira/browse/MSHADE-447
  • Loading branch information
cstamas committed Jun 13, 2023
1 parent 2e7f87a commit f251212
Showing 1 changed file with 5 additions and 20 deletions.
25 changes: 5 additions & 20 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,9 @@
<version>${sisu.version}</version>
</dependency>
<dependency>
<groupId>org.sonatype.sisu</groupId>
<artifactId>sisu-guice</artifactId>
<version>3.2.6</version>
<classifier>no_aop</classifier>
<groupId>com.google.inject</groupId>
<artifactId>guice</artifactId>
<version>5.1.0</version>
</dependency>
</dependencies>
</dependencyManagement>
Expand Down Expand Up @@ -207,9 +206,8 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.sonatype.sisu</groupId>
<artifactId>sisu-guice</artifactId>
<classifier>no_aop</classifier>
<groupId>com.google.inject</groupId>
<artifactId>guice</artifactId>
<scope>test</scope>
</dependency>
<dependency>
Expand Down Expand Up @@ -299,19 +297,6 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.eclipse.sisu</groupId>
<artifactId>sisu-maven-plugin</artifactId>
<version>${sisu.version}</version>
<executions>
<execution>
<goals>
<goal>main-index</goal>
<goal>test-index</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</pluginManagement>

Expand Down

0 comments on commit f251212

Please sign in to comment.