Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRRESOURCES-145] Avoid overwriting the generated file with the same content #50

Merged
merged 3 commits into from Mar 2, 2024

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Feb 26, 2024

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue will be appreciated - as I understood we will stop overriding output files with the same content.

@gnodet
Copy link
Contributor Author

gnodet commented Feb 26, 2024

issue will be appreciated - as I understood we will stop overriding output files with the same content.

I'll raise one, but the effect is rather the opposite. The overwrite flag was effectively removed a while ago, so the filtering mechanism should always ensure that the resource content is copied. The use of a caching output stream avoids writing identical content again and again.

I've just pushed another commit to fix the last execution branch. It'll require a new maven-filtering and I'm planning to release both later this week.

@gnodet gnodet added this to the 3.1.1 milestone Feb 26, 2024
@gnodet gnodet changed the title Use caching output stream [MRRESOURCES-145] Avoid overwriting the generated file with the same content Feb 26, 2024
@gnodet gnodet merged commit 9f5b057 into apache:master Mar 2, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants