Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import KEYS history from svn #240

Merged
merged 94 commits into from
Mar 8, 2025
Merged

import KEYS history from svn #240

merged 94 commits into from
Mar 8, 2025

Conversation

hboutemy
Copy link
Member

@hboutemy hboutemy commented Mar 4, 2025

jvanzyl and others added 30 commits March 4, 2025 17:53
git-svn-id: https://svn.apache.org/repos/asf/maven/project@438217 13f79535-47bb-0310-9956-ffa450edef68

Verified

This commit was signed with the committer’s verified signature.
FrozenPandaz Jason Jean
git-svn-id: https://svn.apache.org/repos/asf/maven/project@485241 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/maven/project@487809 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/maven/project@494420 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/maven/project@523533 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/maven/project@564483 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/maven/project@597468 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/maven/project@599563 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/maven/project@600718 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/maven/project@603071 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/maven/project@632609 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/maven/project@678953 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/maven/project@733534 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/maven/project@746757 13f79535-47bb-0310-9956-ffa450edef68
hboutemy and others added 18 commits March 4, 2025 17:53
git-svn-id: https://svn.apache.org/repos/asf/maven/project@1901710 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/maven/project@1901734 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/maven/project@1912300 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/maven/project@1922406 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/maven/project@1924142 13f79535-47bb-0310-9956-ffa450edef68
@hboutemy hboutemy added the enhancement New feature or request label Mar 4, 2025
@slawekjaranowski
Copy link
Member

What is purpose of it?

KEYS file used in distribution area https://downloads.apache.org/maven/KEYS

has source in https://dist.apache.org/repos/dist/release/maven/KEYS

@slawekjaranowski
Copy link
Member

How we will manage this file in this repository?

@hboutemy
Copy link
Member Author

hboutemy commented Mar 4, 2025

very good questions

has source in https://dist.apache.org/repos/dist/release/maven/KEYS

please take time to read the content: PMC writable only

updates to be done currently at https://svn.apache.org/repos/asf/maven/project/KEYS
then ask PMC to update dist

updating initially in Git instead of svn would ease committer work AND clarify the difference between original source for committers vs publication to dist

@slawekjaranowski
Copy link
Member

updating initially in Git instead of svn would ease committer work AND clarify the difference between original source for committers vs publication to dist

OK, so primary source will be here and after modification a PMC will copy / sync it do dist area - right?

Comment on lines +1 to +12
Edit this file in SVN at https://svn.apache.org/repos/asf/maven/project/KEYS

Then publish to download area /dist/maven/KEYS by

svn co https://dist.apache.org/repos/dist/release/maven dist-maven
cd dist-maven
svn cat https://svn.apache.org/repos/asf/maven/project/KEYS > KEYS

then commit.
Download area publication is a PMC activity. If you are not a PMC member
then email private@maven.apache.org with a request to publish your
modification.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update this instruction also in this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR was about all the svn2git work to get the history (as stated in title)
but of course, updating instructions will be the next step (and I won't do a PR: this is a proof of CTR efficiency for basic updates)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even with CRT and simple changes PR can be valuable 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I fully understand and respect (no fight against)

but TBH, when I am working on 10's of different aspects in parallel in many different Git repos (at ASF and others), it costs so much energy to open PRs here and there, wait, come back on PRs that I remember (eventually forget some), check
=> doing quickly a first commit then having other's feedback by improvement commits on top of the initial commit: this way of reviewing puts less stress and energy cost to me (and review comes in the form of improvements, which I find more positive)

on this one, I wanted a PR because I wanted RTC, but I see that I missed that I need to explain a little bit more my plan as it was not fully obvious that the plan is to migrate one step further from svn to Git

Sorry

@hboutemy hboutemy merged commit 4aaae32 into master Mar 8, 2025
10 checks passed
@hboutemy hboutemy deleted the keys branch March 8, 2025 08:33
@github-actions github-actions bot added this to the 44 milestone Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet