Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addStylesheets Javadoc #261

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Conversation

scordio
Copy link
Contributor

@scordio scordio commented Jan 6, 2024

This fixes also https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#addStylesheets which is currently rendered as:

Screenshot 2024-01-06 at 13 10 12

Sorry, something went wrong.

@slachiewicz slachiewicz added the documentation Improvements or additions to documentation label Jan 6, 2024
@scordio
Copy link
Contributor Author

scordio commented Jan 7, 2024

I see JDK 8 jobs fail but I couldn't figure out what's wrong. Is there anything I should take care of?

@slawekjaranowski
Copy link
Member

build fixed in #264

@elharo
Copy link
Contributor

elharo commented Jan 12, 2024

The build was broken for reasons that had nothing to do with this PR. I triggered a rerun on the jobs post fix. This should be good to go.

@scordio
Copy link
Contributor Author

scordio commented Jan 12, 2024

Thanks @slawekjaranowski and @elharo! I'll rebase my changes soon.

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@slawekjaranowski slawekjaranowski merged commit 1588eae into apache:master Jan 13, 2024
@scordio scordio deleted the fix-javadoc branch January 13, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants