Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MJAVADOC-769] fix for transitive filename based modules #227

Merged
merged 1 commit into from Sep 8, 2023

Commits on Sep 4, 2023

  1. [MJAVADOC-769] fix for transitive filename based modules

    When a project depends on an artifact with a manifest entry for
    Automatic-Module-Name which in turn depends on an artifact that uses the
    filename to determine the module name, it will move the former onto the
    module path and patch the latter into the main artifact. However, now
    the direct dependency on the module path can no longer access the
    classes that have been patched only into the main module and javadoc
    generation fails.
    
    As the JDK only differentiates between modules with a module descriptor
    and "everything else" (modules with an automatic module entry in the
    manifest and modules with file name based names), the javadoc plugin
    should do the same.
    
    This patch changes the treatment of dependencies with an
    Automatic-Module-Name to match dependencies that use a filename based
    module name. The plugin now patches all of those dependencies into the
    main module and the build succeeds.
    
    Includes an integration test.
    hgschmie committed Sep 4, 2023
    Copy the full SHA
    2f133a9 View commit details
    Browse the repository at this point in the history