[MENFORCER-466] Apply the all levels scope and optional selectors on RequireUpperBoundDeps #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarmoniuk
force-pushed
the
MENFORCER-466-provided-optional
branch
2 times, most recently
from
b9ea602
to
bf5f920
Compare
jarmoniuk
commented
Mar 16, 2023
maven-enforcer-plugin/src/it/projects/require-upper-bound-deps-provided/invoker.properties
Outdated
Show resolved
Hide resolved
… optional selectors on RequireUpperBoundDeps
slawekjaranowski
force-pushed
the
MENFORCER-466-provided-optional
branch
from
bf5f920
to
5d29bda
Compare
slawekjaranowski
changed the title
| @@ -49,8 +49,6 @@ public final class DependencyConvergence extends AbstractStandardEnforcerRule { | |||
|
|
|||
| private List<String> excludes; | |||
|
|
|||
| private List<String> scopes = Arrays.asList(Artifact.SCOPE_COMPILE, Artifact.SCOPE_RUNTIME, Artifact.SCOPE_SYSTEM); | |||
There was a problem hiding this comment.
This was a new parameter according to: MENFORCER-470
But ok - I will restore it as exludesScopes
|
rebased 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have corrected the test checking scope provided for
require upper bound deps. It wasn't checking anything. I have enhanced the test to check for actual upper deps for both required and optional.Applied selectors checking for optional and scoped dependencies on all levels (that is, also including direct) for RequireUpperBoundDeps.
ASF rules
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MENFORCER-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.