[MENFORCER-469] Fix banTransitiveDependencies and transitive dependen… #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekjaranowski
force-pushed
the
MENFORCER-469
branch
from
8ddf0c0
to
d5c1af4
Compare
elharo
reviewed
Mar 12, 2023
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/dependency/ResolveUtil.java
Outdated
Show resolved
Hide resolved
| @@ -66,6 +62,24 @@ class ResolveUtil { | |||
| this.session = Objects.requireNonNull(session); | |||
| } | |||
|
|
|||
| /** | |||
| * Retrieves the {@link DependencyNode} instance containing the result of the transitive dependency | |||
There was a problem hiding this comment.
I'm not sure what "the result of the transitive dependency" is exactly. Is this just the transitive dependencies of the current maven project? Consider rephrasing.
There was a problem hiding this comment.
Yes it is for current maven project
There was a problem hiding this comment.
Please rewrite to clarify this
There was a problem hiding this comment.
please look at next lines - there is:
Retrieves the {@link DependencyNode} instance containing the result of the transitive dependency
for the current {@link MavenProject} in verbose mode.
There was a problem hiding this comment.
"the result of the transitive dependency" is unclear. Transitive dependencies are not process and wouldn't normally be thought of as having results.
There was a problem hiding this comment.
So ... can you propose description of this method?
…cies with another version than the resolved one - introduce methods: - resolveTransitiveDependenciesVerbose resolve with full tree contains all dependencies - also conflicted - resolveTransitiveDependencies resolve final tree contains dependencies after conflict resolved
slawekjaranowski
force-pushed
the
MENFORCER-469
branch
from
d5c1af4
to
43e8a3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cies with another version than the resolved one
introduce methods:
resolveTransitiveDependenciesVerbose resolve with full tree contains all dependencies - also conflicted
resolveTransitiveDependencies resolve final tree contains dependencies after conflict resolved
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MENFORCER-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.