Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MENFORCER-470] AdvancedDependencyConvergence rule #246

Merged

Conversation

alexey-anufriev
Copy link
Contributor

@alexey-anufriev alexey-anufriev commented Feb 1, 2023

After the release of v3.2 of the plugin, I discovered some breaking changes in API, thus had problems migrating my rule https://github.com/alexey-anufriev/advanced-enforcer-rules to a new version along with the support of the previous plugin versions.

For this reason, I have reimplemented the missing features directly in the original rule.


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MENFORCER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski
Copy link
Member

For new rule parameter we need a jira issue - please create one

@alexey-anufriev alexey-anufriev changed the title AdvancedDependencyConvergence rule [MENFORCER-470] AdvancedDependencyConvergence rule Mar 7, 2023
@slawekjaranowski slawekjaranowski merged commit da1351a into apache:master Mar 14, 2023
@slawekjaranowski
Copy link
Member

@alexey-anufriev thanks

@alexey-anufriev alexey-anufriev deleted the advanced-dep-convergence branch March 15, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants