Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MENFORCER-435] Replacing maven-compat and maven-dependency-tree usage with Resolver #198

Merged
merged 1 commit into from
Dec 26, 2022
Merged

[MENFORCER-435] Replacing maven-compat and maven-dependency-tree usage with Resolver #198

merged 1 commit into from
Dec 26, 2022

Conversation

jarmoniuk
Copy link
Contributor

See summary; also: dependency:tree is no longer necessary to check parent information of dependencies which triggered validation failures -- path information is included.

@slawekjaranowski please review

@jarmoniuk
Copy link
Contributor Author

I see. I was under the impression that the API for custom rule creators was the enforcer-api module. That was at least what I used when I created the custom enforcer rule in versions-maven-plugin. Didn't know AbstractBanDependencies was intended to be used as API for external rules. Perhaps it should be stated more clearly that it's also part of the API for custom rules.

@jarmoniuk jarmoniuk closed this Dec 16, 2022
@jarmoniuk jarmoniuk reopened this Dec 16, 2022
@jarmoniuk
Copy link
Contributor Author

Closed by mistake... 👀

@jarmoniuk
Copy link
Contributor Author

@olamy could you have a look as well? Thanks!

@jarmoniuk
Copy link
Contributor Author

Also resolves [MENFORCER-434]

@jarmoniuk
Copy link
Contributor Author

I'd also gladly use a DependencySelector to exclude artifacts already at the dependency node retrieval level, but if you say everything is public API, I'm not sure whether I am allowed to modify any class. @slawekjaranowski could you please help out?

@jarmoniuk jarmoniuk force-pushed the MENFORCER-435 branch 2 times, most recently from 912bd4e to 34fb709 Compare December 17, 2022 17:57
@jarmoniuk
Copy link
Contributor Author

Looks like javadoc linter was upset with BannedDependenciesBase (which I'd rather not have and use the old AbstractBannedDependencies instead). Corrected.

slawekjaranowski
slawekjaranowski approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash to final commit and rebase with current master

@jarmoniuk
Copy link
Contributor Author

Rebased and squashed.

@jarmoniuk
Copy link
Contributor Author

@slawekjaranowski your newest it failed. Checking.

@jarmoniuk
Copy link
Contributor Author

jarmoniuk commented Dec 24, 2022 •
edited

It's been so long that I had forgotten the reasons why I did things like I did -- e.g. use bespoke dependency selectors instead of the regular ones (the reason for that being that the out of the box selectors only work on transitive dependencies).

So I commented that piece.

@jarmoniuk
Copy link
Contributor Author

jarmoniuk commented Dec 24, 2022 •
edited

I mean, it would be nice if there were also selectors working on direct dependencies, but that would require changes (PR) to Resolver 🤡

@slawekjaranowski slawekjaranowski merged commit 919fe02 into apache:master Dec 26, 2022
@jarmoniuk jarmoniuk deleted the MENFORCER-435 branch December 26, 2022 16:02
@pzygielo
Copy link
Contributor

pzygielo commented Feb 4, 2023

Seems it might have caused MENFORCER-466, as 919fe02 is reported as first bad commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwin kwin kwin left review comments

@slawekjaranowski slawekjaranowski Awaiting requested review from slawekjaranowski

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
4 participants
@jarmoniuk @pzygielo @kwin @slawekjaranowski