[MENFORCER-473] Notice about max JDK in custom rules

apache · Mar 30, 2023 · 607df6b · 607df6b
1 parent 435807f
commit 607df6b
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 17 deletions.
diff --git a/enforcer-api/pom.xml b/enforcer-api/pom.xml
@@ -97,15 +97,6 @@
           </execution>
         </executions>
       </plugin>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-site-plugin</artifactId>
-        <configuration>
-          <attributes>
-            <mavenPrerequisite>${maven.version}</mavenPrerequisite>
-          </attributes>
-        </configuration>
-      </plugin>
     </plugins>
   </build>
 </project>
diff --git a/enforcer-api/src/custom-rule-sample/pom.xml b/enforcer-api/src/custom-rule-sample/pom.xml
@@ -33,8 +33,8 @@
 
   <properties>
     <api.version>${project.version}</api.version>
-    <maven.version>${maven.version}</maven.version>
-    <!-- use JDK 1.8 at least -->
+    <mavenVersion>${mavenVersion}</mavenVersion>
+    <!-- use JDK 1.8 or 11 -->
     <maven.compiler.source>1.8</maven.compiler.source>
     <maven.compiler.target>1.8</maven.compiler.target>
   </properties>
@@ -49,7 +49,7 @@
     <dependency>
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-core</artifactId>
-      <version>\${maven.version}</version>
+      <version>\${mavenVersion}</version>
       <scope>provided</scope>
     </dependency>
     <dependency>

diff --git a/enforcer-api/src/site/apt/writing-a-custom-rule.apt.vm b/enforcer-api/src/site/apt/writing-a-custom-rule.apt.vm
@@ -36,6 +36,8 @@ Writing a custom rule
 
 %{snippet|id=project-pom|file=enforcer-api/target/custom-rule-sample/pom.xml}
 
+  Target bytecode version of rule must be <<<1.8>>> or <<<11>>> - due to {{{https://issues.apache.org/jira/browse/MENFORCER-473}MENFORCER-473}}.
+
   Note that the classloader is shared with the embedding <<<maven-enforcer-plugin>>> (a regular {{{https://maven.apache.org/guides/mini/guide-maven-classloading.html#Plugin_Classloaders}plugin classloader}})
   and therefore the artifacts <<<org.apache.maven.enforcer:enforcer-api>>> are always loaded in the same version as the embedding <<<maven-enforcer-plugin>>>.
 

diff --git a/maven-enforcer-plugin/pom.xml b/maven-enforcer-plugin/pom.xml
@@ -35,7 +35,7 @@
   <description>The Loving Iron Fist of Maven</description>
 
   <prerequisites>
-    <maven>${maven.version}</maven>
+    <maven>${mavenVersion}</maven>
   </prerequisites>
 
   <dependencies>

diff --git a/pom.xml b/pom.xml
@@ -77,7 +77,7 @@
   </distributionManagement>
 
   <properties>
-    <maven.version>3.2.5</maven.version>
+    <mavenVersion>3.2.5</mavenVersion>
     <maven.site.path>enforcer-archives/enforcer-LATEST</maven.site.path>
     <javaVersion>8</javaVersion>
     <mockito.version>4.11.0</mockito.version>
@@ -111,19 +111,19 @@
       <dependency>
         <groupId>org.apache.maven</groupId>
         <artifactId>maven-artifact</artifactId>
-        <version>${maven.version}</version>
+        <version>${mavenVersion}</version>
         <scope>provided</scope>
       </dependency>
       <dependency>
         <groupId>org.apache.maven</groupId>
         <artifactId>maven-plugin-api</artifactId>
-        <version>${maven.version}</version>
+        <version>${mavenVersion}</version>
         <scope>provided</scope>
       </dependency>
       <dependency>
         <groupId>org.apache.maven</groupId>
         <artifactId>maven-core</artifactId>
-        <version>${maven.version}</version>
+        <version>${mavenVersion}</version>
         <scope>provided</scope>
       </dependency>
       <dependency>