Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDEP-939] Lock down classifier in dependency:sources goal #409

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

michael-o
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MDEP-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MDEP-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Sorry, something went wrong.

asfgit pushed a commit that referenced this pull request Jun 7, 2024
This closes #409
@asfgit asfgit force-pushed the lock-down-classifier branch from dd1f2f7 to a44eb5a Compare June 7, 2024 22:08
@michael-o michael-o changed the title Lock down classifier [MDEP-939] Lock down classifier in dependency:sources goal Jun 7, 2024
@@ -16,3 +16,4 @@
# under the License.

outputFile = target/resolved.txt
classifier = foo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may require a comment that it has no influence anymore...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test can be useful ... even we have a read only property user still can override it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and there are no assertions in this test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess at least the build should not fail, but need to try...

@slawekjaranowski
Copy link
Member

Looks ok - even more classifier parameter disappears from plugin documentation

@michael-o
Copy link
Member Author

Looks ok - even more classifier parameter disappears from plugin documentation

This is a nice bonus or a bug in the Plugin Tools.

@slawekjaranowski
Copy link
Member

Looks ok - even more classifier parameter disappears from plugin documentation

This is a nice bonus or a bug in the Plugin Tools.

works as expected - documentation was taken from the final class - as we have read-only property is hidden

@michael-o
Copy link
Member Author

Looks ok - even more classifier parameter disappears from plugin documentation

This is a nice bonus or a bug in the Plugin Tools.

works as expected - documentation was taken from the final class - as we have read-only property is hidden

Perfect, thanks.

@michael-o michael-o marked this pull request as ready for review June 8, 2024 10:07

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This closes #409
@asfgit asfgit force-pushed the lock-down-classifier branch from a44eb5a to 04c3216 Compare June 8, 2024 18:55
@asfgit asfgit closed this in 04c3216 Jun 8, 2024
@asfgit asfgit merged commit 04c3216 into master Jun 8, 2024
4 of 17 checks passed
@michael-o michael-o deleted the lock-down-classifier branch June 8, 2024 19:23
@michael-o
Copy link
Member Author

FTR: All resolve ITs missing verifiers, this needs to be addressed as a whole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants