MDEP-938] Correct invalid property name and add deprecated old one #404
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
property = "mdep.overIfNewer" is incorrect as a mismatch on the naming and should have been "mdep.overWriteIfNewer" to respect naming convention as all others do. All examples show using the more general property as 'overWriteIfNewer' so its odd to pass -Dmdep.overIfNewer instead of expected correct value. I suspect this is a rare situation and was not an issue that I had but something I noticed when reviewing the code. The original PR I opened #285 went unmerged and was requested to add a deprecated property for the original along with jira. Due to how its used, I didn't see a very good way to make the invalid usage populate the correct one. Maybe there is a better way here. So for now, the misnamed original 'mdep.overIfNewer' is over a property that is unused simply noting its deprecation. I added since 3.7.0 which is also odd considering this is simply a fix and the original is entirely still used throughout as it was entirely correct. Just the property name attribute was incorrect.
I otherwise didn't add any new tests or anything to this situation but could if needed. Might be better if some error is thrown if the original is even populated as I suspect this along is not enough to indicate it got deprecated since that won't show up in the use case.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MDEP-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MDEP-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.