Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHARED-1407] Track dependency usage by referencing classes #125

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

jaredstehler
Copy link
Contributor

This enhances the functionality which shows specific classes in use per dependency, by mapping those uses to classes which are referencing them.

The resulting API addition is:

Set<DependencyUsage> analyzeUsages(URL url, ClassesPatterns excludeClasses)

which I plan on adding a PR to maven-dependency-plugin to show how we use this feature in practice.

This was originally proposed via this PR #20 which was closed due to lack of support for default interface methods prior to JDK8.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes. Also be sure having selected the correct component.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSHARED-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSHARED-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* track dependency usages by declaring class
@slawekjaranowski slawekjaranowski self-assigned this Jun 2, 2024
@slawekjaranowski slawekjaranowski added the enhancement New feature or request label Jun 2, 2024
@jaredstehler
Copy link
Contributor Author

Updated with all inadvertant formatting and import changes reverted.

@slawekjaranowski slawekjaranowski merged commit 064fa0e into apache:master Jun 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants