Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCOMPILER-577] Rename parameter "forceJavacCompilerUse" #225

Merged
merged 1 commit into from Feb 26, 2024

Conversation

kwin
Copy link
Member

@kwin kwin commented Feb 26, 2024

Clarify meaning in javadoc

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@kwin kwin force-pushed the feature/rename-parameter-forceJavacCompilerUse branch from 0d9cd09 to 4ebcac8 Compare February 26, 2024 11:05
@kwin
Copy link
Member Author

kwin commented Feb 26, 2024

@slawekjaranowski The next version should increase the minor version part due to the introduction of a new parameter.

@kwin kwin merged commit c2326c6 into master Feb 26, 2024
148 checks passed
@kwin kwin deleted the feature/rename-parameter-forceJavacCompilerUse branch February 26, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants